Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When making the window more narrow, header bar doesn't expand #162

Closed
psobolewskiPhD opened this issue May 3, 2024 · 5 comments · Fixed by #163
Closed

When making the window more narrow, header bar doesn't expand #162

psobolewskiPhD opened this issue May 3, 2024 · 5 comments · Fixed by #163

Comments

@psobolewskiPhD
Copy link
Member

The items in the header go multiline, but the header area (blue bar) doesn't expand.

image

Compare to parent pydata-sphinx-theme:
image

The header bar widens to accommodate the double-line. I don't love the aesthetic, but it is objectively better than ours 🤣

@melissawm
Copy link
Member

ooh interesting! Probably an upstream bug - would you mind opening an issue there?

@psobolewskiPhD
Copy link
Member Author

I don't think it's upstream bug, I think I just wasn't clear:
Upstream wide look like this:
image

And if you narrow it you can see the header space expands vertically--it between the shadow at the bottom and the purple banner:
image

In our case, here is the wide view:
image

Looks much like upstream.
But when I narrow it:
image

The blue header doesn't expand in the vertical direction (GitHub is auto sizing to fit width here, but I think you can see what's happening)

@psobolewskiPhD
Copy link
Member Author

Apropos, upstream has a PR to improve the default look:
pydata/pydata-sphinx-theme#1784
(but our issue is still something different, with the blue bar graphic not expanding)

@gabalafou
Copy link
Contributor

Hi, I landed here from the cross-reference to the PyData Theme issue (1784). I think you can fix this issue by removing the height: 64px on the header. I'm not familiar enough with Napari docs to know if that's a viable solution, maybe you have an animation or some other reason you need to set the height explicitly, but if you don't need to set an explicit, fixed height, that should fix this issue, which is what I did in PR #163

@melissawm
Copy link
Member

No we dont have any customization beyond the color, I will try that, thanks! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants