Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextJS 15 #499

Open
edisonhuff opened this issue Nov 8, 2024 · 3 comments
Open

nextJS 15 #499

edisonhuff opened this issue Nov 8, 2024 · 3 comments

Comments

@edisonhuff
Copy link

Heyo

With the caching and async reworks done in nextJS 15 I'm a little worried of trying to upgrade my solito project on next 14.

Does solito work with next 15? If not are there plans to update solito for next 15?

@nandorojo
Copy link
Owner

Hey, good question. I would assume so since there aren’t big breaking changes that I know of, but I still have to test it

@edisonhuff
Copy link
Author

The big ones I heard about include changing cookie / header / params / search params to be async instead of sync
https://nextjs.org/blog/next-15#async-request-apis-breaking-change

In case you'd like to check the full list:
https://nextjs.org/blog/next-15#other-changes

@iknowhtml
Copy link

Not a blocker, but I see the following warning when I use Next.js 15 with Solito when I run the local development server/builds:

../node_modules/react-native-web/dist/exports/render/index.js
Attempted import error: 'hydrate' is not exported from 'react-dom' (imported as 'domLegacyHydrate').

Import trace for requested module:
../node_modules/react-native-web/dist/exports/render/index.js
../node_modules/react-native-web/dist/index.js
./app/providers.tsx

../node_modules/react-native-web/dist/exports/unmountComponentAtNode/index.js
Attempted import error: 'unmountComponentAtNode' is not exported from 'react-dom' (imported as 'unmountComponentAtNode').

Import trace for requested module:
../node_modules/react-native-web/dist/exports/unmountComponentAtNode/index.js
../node_modules/react-native-web/dist/index.js
./app/providers.tsx

providers.tsx File:

'use client';

import { useServerInsertedHTML } from 'next/navigation';
import { StyleSheet } from 'react-native';

export const StylesProvider = ({ children }: React.PropsWithChildren) => {
  useServerInsertedHTML(() => {
    // @ts-ignore -- Need below for Solito: https://solito.dev/app-directory/overview#appstyles-providertsx
    const sheet = StyleSheet.getSheet();
    return (
      //
      <style
        // biome-ignore lint/security/noDangerouslySetInnerHtml: Required for Solito Router set up: https://solito.dev/app-directory/overview#appstyles-providertsx
        dangerouslySetInnerHTML={{ __html: sheet.textContent }}
        id={sheet.id}
      />
    );
  });

  return <>{children}</>;
};

Seems related to: gilbarbara/react-joyride#1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants