Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target blank is not propagated to next/link #452

Open
1 of 3 tasks
seeden opened this issue Nov 24, 2023 · 6 comments
Open
1 of 3 tasks

target blank is not propagated to next/link #452

seeden opened this issue Nov 24, 2023 · 6 comments

Comments

@seeden
Copy link

seeden commented Nov 24, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Do you want this issue prioritized?

  • Yes, I have sponsored
  • Not urgent

Current Behavior

When you use <Link href="/privacy" target="_blank"> it will show <a href="/privacy">

Expected Behavior

When you use <Link href="/privacy" target="_blank"> it will show <a href="/privacy" target="_blank">

Steps To Reproduce

import { Link } from 'solito/next'

return (Privacy);

Versions

- Solito: 4.1.2
- Next.js: 14.0.3
- Expo: 49.0.18
- React Native: 0.72.6

Screenshots

No response

Reproduction

No response

@nandorojo
Copy link
Owner

Published in 4.2.0: https://github.com/nandorojo/solito/releases/tag/v4.2.0

@seeden
Copy link
Author

seeden commented Dec 12, 2023

thank you @nandorojo

@cglacet
Copy link
Contributor

cglacet commented Feb 2, 2024

Are you guys certain in works in 4.2.0?

I tested it with Next.js 13.5.6 but it doesn't seem to work for me.

@cglacet
Copy link
Contributor

cglacet commented Dec 11, 2024

That still doesn't work in 4.3 saddly.

@nandorojo nandorojo reopened this Dec 11, 2024
@nandorojo
Copy link
Owner

Reopened

@nandorojo
Copy link
Owner

I suspect it’s due to RNW, I will see if I can address it. It’s a moving target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants