Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panics cause shell to no longer echo input nor show commands #1101

Open
kriswuollett opened this issue Feb 7, 2023 · 1 comment
Open

panics cause shell to no longer echo input nor show commands #1101

kriswuollett opened this issue Feb 7, 2023 · 1 comment
Labels
devex Tackles devex issues linear

Comments

@kriswuollett
Copy link

kriswuollett commented Feb 7, 2023

After panic noted in #1100 the shell no longer echos keyboard input nor shows the command that would be executed if [Enter] is pressed.
This occurred for me on Ubuntu 22.04 x86_64 in both Code and Terminal apps when running in Unity window manager.

Expectation is that the shell should not be affected after a program crash.

Screencast.from.02-07-2023.12.42.37.PM.webm
@hugosantos
Copy link
Contributor

Note to us: The challenge here is that terminal restoration is done by bubbletea. Which does perform cleanup on panics. But the panic is not observed by its goroutine.

@hugosantos hugosantos added devex Tackles devex issues and removed needs-triage labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devex Tackles devex issues linear
Projects
None yet
Development

No branches or pull requests

2 participants