Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring 'bootstrap3-dialog' in Webpack/Laravel Mix results in Bootstrap/Navbar javascript not working #378

Open
mseymour opened this issue May 18, 2018 · 3 comments

Comments

@mseymour
Copy link

mseymour commented May 18, 2018

I'm in the process of converting over my Laravel Elixir asset pipeline which uses Gulp over to Laravel Mix which uses Webpack, and I've come into an issue where at the least the navbar dropdowns (and possibly other Bootstrap-sass javascript features) no longer work.

Is there something specific that I should do to make it work? The latest versions of Bootstrap-sass and Bootstrap3-dialog that I have are 3.3.7 and ^1.35.4.

@kotarCreative
Copy link

Are you requiring them in your app.js or bootstrap.js file? Can we see your webpack.mix.js and package.json file to try and track down what missing?

@isdrone
Copy link

isdrone commented Jul 28, 2018 via email

@BenAttenborough
Copy link

I'm a bit new to webpack, but since the release of bootstrap 4 the npm module for webpack 3 is now called 'webpack3'. Therefore could I suggest that:

module.exports = factory(require('jquery'), require('bootstrap'));

is changed to:

module.exports = factory(require('jquery'), require('bootstrap3'));

And a similar change to line 24.

At the moment installing the dialog module via npm and requiring it causes a build error because it is looking for a non-existent 'bootstrap' module

either that or the project is made compatible with bootstrap 4? (Preferably both so bs 3 legacy users can continue using it).

I hope that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants