Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IOS skippable ads fullscreen toggle #2

Open
mysuf opened this issue May 2, 2018 · 1 comment
Open

fix IOS skippable ads fullscreen toggle #2

mysuf opened this issue May 2, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mysuf
Copy link
Owner

mysuf commented May 2, 2018

Now, it behaves exactly how https://developers.google.com/interactive-media-ads/docs/sdks/html5/skippable-ads describes. It forces content player to enter/exit fullscreen which break fullscreen implementation on mobile IOS. The solution will be probably not supporting tech's fullscreen on IOS and to force full window instead.

The question is how it should work when content player is already in fullscreen - programatically exited fullscreen and switch to full window could lead to blinking and bad user experience...

@mysuf mysuf self-assigned this May 7, 2018
@mysuf mysuf added the bug Something isn't working label May 11, 2018
@mysuf
Copy link
Owner Author

mysuf commented Jun 10, 2018

One solution is adding browser-manager plugin to ima player. When iOS detected, it would add playsinline attribute to tech element and override content player's enter/exit fullscreen methods by passing enter/exit fullWindow methods instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant