-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-unused-disable is redundant #80
Comments
Here's the link to the ESLint v9 docs: https://eslint.org/docs/next/use/configure/configuration-files#reporting-unused-disable-directives
It also has auto-fix, so running |
Hi @CruseCtrl! Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org |
Thanks, I didn't realise this was unmaintained. I'll maybe raise an issue on the forked one |
In the docs it says
While this is true, ESLint also provides the
reportUnusedDisableDirectives
config option, which can be configured in shareable configs: https://eslint.org/docs/latest/use/configure/rules#report-unused-eslint-disable-commentsAnd the default value of that option was changed to
true
a few weeks ago, so will probably be included as a default setting with ESLint v9: eslint/eslint#17879I propose that
no-unused-disable
should be deprecated, and removed in a future releaseThe text was updated successfully, but these errors were encountered: