Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this with eslint-plugin-canonical #65

Open
gajus opened this issue Oct 25, 2021 · 2 comments
Open

Merge this with eslint-plugin-canonical #65

gajus opened this issue Oct 25, 2021 · 2 comments

Comments

@gajus
Copy link

gajus commented Oct 25, 2021

Hey @mysticatea,

Would you be oppose if the rules in this plugin were merged into https://github.com/gajus/eslint-plugin-canonical this plugin?

I am trying to consolidate efforts around some of the more niche plugin maintenance to make it easier to handle upgrades such as the requirements moving from ESLint v7 to v8 support.

I would do all the work.

@Vages
Copy link

Vages commented Nov 10, 2021

You may already know this, but in case not: This project is MIT licensed, so copying the entire package – or parts of it – is probably within the boundaries of the law and developer courtesy (as long as you follow the terms of the license): https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/LICENSE

Looking forward to seeing the rules in eslint-plugin-canonical!

@gajus
Copy link
Author

gajus commented Nov 10, 2021

It's less about the license, and more about making sure that this would be a value additive contribution. If @mysticatea intends to continue working on this project, then it makes little sense to copy them to Canonical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants