Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read environment properties files in ZIP/JAR archive #122

Open
h3adache opened this issue May 23, 2018 · 3 comments
Open

Read environment properties files in ZIP/JAR archive #122

h3adache opened this issue May 23, 2018 · 3 comments

Comments

@h3adache
Copy link
Member

A built in jar migration loader would be nice.
I'm reuse my own jar migration loader quite a bit atm.

@harawata
Copy link
Member

If a custom migration loader is built-in, it'll be picked up by SPI, I think.

I haven't tested it, but if it's published as a separate module on Maven Central or Bintray JCenter, users of Maven/Gradle plugin may be able to use it just by adding it as a dependency.

@h3adache
Copy link
Member Author

Hi @harawata! Sorry for the late response. I've been away.
The problem isn't with the custom migration loader, it's due to when it reads environment/xx.properties
This is assumed to be on the file system and not able to read using the migration loader.
A file loader strategy or {{ResourceLoader}} like Spring has would be a solution here.

@harawata
Copy link
Member

@h3adache ,
It may be possible to provide another extension point like custom file migration loader.
I'll look into it.

@harawata harawata changed the title Jar (Archive/Zip?) Migration Loader Read environment properties files in ZIP/JAR archive Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants