-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show(df)
does not work with modin.pandas
#325
Comments
Hi @wpritom , thanks for reporting this! Yes that's right currently ITables only supports Pandas and Polars DataFrames. Can you convert You can leave this issue open so that I look to add support for Modin DataFrames when time permits. Thanks. |
Hi @mwouts - would you be open to using Narwhals in ITables? I think this could simplify some of the code, e.g. this, and would also give you support for pandas / Polars / Modin / cuDF / PyArrow (and any other Narwhals-compatible eager dataframe), without making any of them required dependencies Happy to make a PR if you'd be interested, just gauging interest first |
Hey @MarcoGorelli , Narwhals sounds like a great package indeed! And sure I would love to provide support for more dataframe types, see for instance #217 (pending) where I started working on Ibis support. I would love to see how that part of the code would look like with Narwhals! The parts that we would need to rewrite that I am currently thinking of (there might be more) are
Looking forward to hearing more from you! |
Hi @mwouts, I'm working on this. |
Hi @wpritom , we're getting something that is starting to work - huge thanks to @DeaMariaLeon and to @MarcoGorelli ! Can you give a try at this PR and let us know how it works for you?
Also I am not familiar with Last but not least I see warnings on my empty dataframes in the sample dataframe notebook (
|
show()
is not working while I'm importing pandas with from modin. I'm using modin to improve pandas performance.Now
show(df, classes="display")
column showing the following error.The text was updated successfully, but these errors were encountered: