Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting 5XX responses as an error on Lambda #4

Open
muratcorlu opened this issue Oct 31, 2019 · 0 comments
Open

Reporting 5XX responses as an error on Lambda #4

muratcorlu opened this issue Oct 31, 2019 · 0 comments
Labels
question Further information is requested

Comments

@muratcorlu
Copy link
Owner

In current situation, if you do this;

response.status(500).end();

requester will get Internal server error but this will be logged as a successful response on Lambda side. I'm not completely sure what is the best practice for this but I feel that, 5XX statuses should be reported as errors on Lambda level too. Because that kind of errors should mean pointing a coding issue in Lambda function.

For now, the only place that we report an error on lambda level is in lambda-wrapper.js function(use function).

@muratcorlu muratcorlu added the question Further information is requested label Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant