-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetBSD irqstats plugin produces faulty output, causing storage blowout on server #1537
Comments
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
May 11, 2023
Copy the current state of sysutils/munin-node from pkgsrc as prep for working on the package to locally fix the irqstats bug, upstream: munin-monitoring/munin#1537 Signed-off-by: Alexander Schreiber <[email protected]>
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
May 11, 2023
The munin-node irqstats plugin produces invalid data by incorporating the field value into the field name, leading to all kinds of annoyances upstream bug: munin-monitoring/munin#1537 Signed-off-by: Alexander Schreiber <[email protected]>
If someone submits a pull request, eventually the downstream patch in NetBSD can be eliminated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The bundled plugins/node.d.netbsd/irqstats.in for munin-2.0.69 produces incorrect output the includes the value
of an entry into the name of the entry, causing copious amounts of unique entries to appear. Was found when I was
wondering exactly why munin would (rapidly) consume 8+GB for < 100 nodes. This bug easily creates 10k+ files
in a few days because of that. Oh, and of course the data is utterly useless as well for the same reason.
The faulty output looks like this (short excerpt only):
The expected output would be this:
To Reproduce
Steps to reproduce the behavior:
Invoke the irqstats plugin on a sufficiently (observed with at least NetBSD 9.0, but I'm pretty sure I saw
it on earlier ones too) NetBSD machine (reproduced on: i386, amd64, sparc64), see the output:
Expected behavior
Expected output would look like this:
Screenshots & Logs
If applicable, please add screenshots and/or logs to help explain your problem.
Desktop (please complete the following information):
OS: NetBSD 9.1, NetBSD 9.2, NetBSD 9.3
Munin version: 2.0.69
Additional context
I've been running a rewritten version of the irqstats plugin for NetBSD for ... a few months at least now, this
one works and produces the expected output:
The text was updated successfully, but these errors were encountered: