Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"human-readable" CID form should match spec #39

Open
olizilla opened this issue Jun 14, 2021 · 1 comment
Open

"human-readable" CID form should match spec #39

olizilla opened this issue Jun 14, 2021 · 1 comment

Comments

@olizilla
Copy link
Collaborator

...or spec should match what this site does.

https://github.com/multiformats/cid#human-readable-cids

# corresponding human readable CID
base58btc - cidv1 - raw - sha2-256-256-6e6ff7950a36187a801613426e858dce686cd7d7e3c0fc42ee0330072d245c95

https://cid.ipfs.io/#zb2rhe5P4gXftAwvA4eXQ5HJwsER2owDyS9sKaQRRVQPn93bA

Human readable CID
base58btc - cidv1 - raw - (sha2-256 : 256 : 6E6FF7950A36187A801613426E858DCE686CD7D7E3C0FC42EE0330072D245C95)
@lidel
Copy link
Member

lidel commented Jun 15, 2021

I'm 👍 for making things more clear, but sha2-256-256- is confusing: a reader does not know where hash name ends, and where length starts without a double take.

(a : b : c) removes ambiguity + makes it clear which segments are part of multihash, but perhaps there is better way of showing this? I think we should update specs and make them more clear, and them make cid.ipfs.io follow it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants