Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Support for Dialog-Based Forms #4329

Open
aress31 opened this issue Oct 29, 2024 · 2 comments
Open

Implement Support for Dialog-Based Forms #4329

aress31 opened this issue Oct 29, 2024 · 2 comments
Labels
new feature New feature or request scope: toolpad-core Abbreviated to "core" waiting for 👍 Waiting for upvotes

Comments

@aress31
Copy link

aress31 commented Oct 29, 2024

Summary

It would be great to add support for dialog-based forms. The DialogProvider already accommodates payload, prompt, and other types of dialogs. However, displaying forms in a dialog box is a common use case. By enhancing this functionality and possibly implementing a JSON configuration file to define fields that support multiple types—such as autocomplete and select—similar to the colDef in the DataGrid, we could significantly improve the user experience.

Examples

image

Motivation

Enhance the use case for the DialogProvider to make it more developer-friendly by enabling the use of dialog-based forms without requiring developers to manually implement all the form and validation logic.

Search keywords: dialogprovider form

@aress31 aress31 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 29, 2024
@Janpot
Copy link
Member

Janpot commented Oct 29, 2024

Forms and json based forms are definitely concepts we like to have on our roadmap. I see this feature request as a natural combination of those concepts with the dialog provider 👍

it won't be there tomorrow, but fits fully within the scope of toolpad core.

@Janpot Janpot added new feature New feature or request waiting for 👍 Waiting for upvotes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 29, 2024
@aress31
Copy link
Author

aress31 commented Oct 29, 2024

@Janpot, awesome! I'm looking forward to this feature—it'll definitely help simplify my application and reduce boilerplate code. I imagine the JSON/JS file being similar to what's already in place for DataGrid, with methods like getValue, render, etc.

@prakhargupta1 prakhargupta1 added the scope: toolpad-core Abbreviated to "core" label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request scope: toolpad-core Abbreviated to "core" waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

3 participants