Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material UI Sync plugin returning some colour tokens as "null" #425

Open
kaylin-index opened this issue Dec 3, 2024 · 0 comments
Open
Assignees
Labels
figma scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@kaylin-index
Copy link

kaylin-index commented Dec 3, 2024

Steps to reproduce

Steps:

  1. Start with the MUI Figma design file v6.1.0
  2. In local variables, copy-paste the "grey" colour tokens from the "material/colors" variable collection to the "palette" collection
  3. Delete the "material/colors" collection
  4. Double-click the "grey" group title and rename to "common/grey". This will group it under the existing "common" group.
  5. In the left nav of the local variables window, drag the "grey" group out of the "common" group
  6. Run the Material UI Sync Figma plugin to generate a theme file

Current behavior

All my grey tokens are exporting as "null" in the generated JSON file. I've attached the JSON theme file, and a screenshot of the impacted colours from the local variables window in Figma.
theme.json
Screenshot 2024-12-03 at 11 36 58 AM

Expected behavior

All colour tokens are exported properly

Context

I moved the location of the grey colours around several times. Not sure if this is what caused the issue.

  • Previously the grey colours were in the default "material/colors" variable collection but I wanted to consolidate my colours so I moved them into the "palette" collection. Moved via copy-paste.
  • Then I grouped them under "common" with the black and white colours.
  • Then decided to take them out of the "common" group and just have them in their own folder to better match the structure I saw in the default theme viewer.

Your environment

Software Version
Design file version v6.1.0
Design tool Figma v124.6.5
etc.

Search keywords: scope: sync, palette, figma, null, tokens

@kaylin-index kaylin-index added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 3, 2024
@zannager zannager added figma scope: sync Issues related to the Material UI Sync Figma plugin labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
figma scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants