Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][CardActionArea] Added demo in docs of cards for adding props to CardActionArea #44789

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[docs][CardActionArea] Added demo in docs of cards for adding props to CardActionArea #44789

wants to merge 15 commits into from
+140 −0

Conversation

siddhantantil39
Copy link
Contributor

@siddhantantil39 siddhantantil39 commented Dec 16, 2024 •
edited by siriwatknp
Loading

closes #44730

This PR consists of a new demo showcasing adding for adding props/attributes to CardActionArea components.
In this onClick behaviour select the clicked card.

@siddhantantil39 siddhantantil39 mentioned this pull request Dec 16, 2024
Open
@siddhantantil39
Copy link
Contributor Author

This PR relates to issue: #44730

@mui-bot
Copy link

mui-bot commented Dec 16, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ea1a258

@siddhantantil39 siddhantantil39 changed the title Added demo in docs of cards for adding props to CardActionArea [docs][CardActionArea] Added demo in docs of cards for adding props to CardActionArea Dec 16, 2024
@zannager zannager added docs Improvements or additions to the documentation component: card This is the name of the generic UI component, not the React module! labels Dec 17, 2024
@siddhantantil39
Copy link
Contributor Author

Hi all, can anyone review the PR please?

siriwatknp
siriwatknp approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I simplified the demo and docs a bit. I'll wait for @samuelsycamore approval.

@siddhantantil39
Copy link
Contributor Author

Thanks for simplifying the code @siriwatknp. Looks much clearer

@siddhantantil39
Copy link
Contributor Author

@samuelsycamore Upon seeing your review comments, I have committed them. I also understood that the styles make the card look active, it not actually being active. Thanks.

siddhantantil39
siddhantantil39 commented Dec 20, 2024
View reviewed changes
Copy link
Contributor Author

@siddhantantil39 siddhantantil39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samuelsycamore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: card This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CardActionArea] Add an Active Prop
5 participants
@siddhantantil39 @mui-bot @siriwatknp @samuelsycamore @zannager