Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs]: bug, Endless update state in updateScrollButtonState #10751

Closed
tkvw opened this issue Mar 21, 2018 · 4 comments
Closed

[Tabs]: bug, Endless update state in updateScrollButtonState #10751

tkvw opened this issue Mar 21, 2018 · 4 comments
Labels
status: waiting for author Issue with insufficient information

Comments

@tkvw
Copy link
Contributor

tkvw commented Mar 21, 2018

When the clientwidth is of a specific width the Tabs component with a couple of tabs, the Tabs component will call updateScrollButtonState in an endless loop. This happens because the clientWidth changes when the state is changed to visible/hidden.
The component should take this additional space into consideration when setting showRightScroll and showLeftScroll. In this screenshot you see each step and that showRightScroll is changed after each step and is causing the endless loop.
2018-03-21_09-48-59

@oliviertassinari
Copy link
Member

@tkvw Do you have a reproduction example?

@tkvw
Copy link
Contributor Author

tkvw commented Mar 21, 2018

@oliviertassinari : no, this happens inside my application. When I have time I can try to create an example, hoped the debugging screenshot was clear enough. showRightscroll is true => width increases, showRightscroll is false => width decreases,

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Mar 21, 2018
@tkvw
Copy link
Contributor Author

tkvw commented Mar 22, 2018

It happens on react-admin not sure if this is a react-admin issue or material-ui issue:
https://github.com/marmelab/admin-on-rest/issues/1689

@oliviertassinari
Copy link
Member

Your issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

2 participants