Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popups] Clicking outside of nested popups closes all of them #1107

Closed
michaldudak opened this issue Dec 16, 2024 · 2 comments · Fixed by #1161
Closed

[popups] Clicking outside of nested popups closes all of them #1107

michaldudak opened this issue Dec 16, 2024 · 2 comments · Fixed by #1161
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: select This is the name of the generic UI component, not the React module!

Comments

@michaldudak
Copy link
Member

Whenever there are nested popups open, such as a Menu or a Select in a Dialog, clicking outside of them closes all of them. The correct behavior would be to close just the topmost one (as nested Dialogs currently behave).
@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! component: popover The React component. labels Dec 16, 2024
@mj12albert mj12albert self-assigned this Dec 18, 2024
@mj12albert
Copy link
Member

I'll work on this one

@mj12albert mj12albert linked a pull request Dec 18, 2024 that will close this issue
[Menu, Select, Dialog] Use internal backdrop for pointer modality #1161
Merged
@mj12albert mj12albert removed their assignment Dec 18, 2024
@mj12albert
Copy link
Member

It's fixed in https://deploy-preview-1161--base-ui.netlify.app/experiments/popups-in-popups

This was referenced Dec 19, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Menu, Select, Dialog] Use internal backdrop for pointer modality atomiks/base-ui
2 participants
@michaldudak @mj12albert