Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when gitty does not find either GITHUB_TOKEN or GITTY_TOKEN - open the browser with the link to create one #16

Open
elbosso opened this issue Sep 7, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@elbosso
Copy link

elbosso commented Sep 7, 2021

it would be best, if the form would then be pre-filled with the needed permissions

@FiXato
Copy link
Contributor

FiXato commented Sep 7, 2021

While I do like the idea of offering to open the browser with the appropriate 'create token' link, I'm not sure if I would do it automatically. Sometimes I'm in a session where I've forgotten to load the appropriate env variables, and would not like it to automatically open my browser.

Maybe offer to open it instead (e.g. wait for user input, so the user can ctrl-c (or answer 'no')) so they can abort if they don't want to create a new token?

Pre-filling it with needed permissions shouldn't be an issue though; just use the same link as used in #14 .

@elbosso
Copy link
Author

elbosso commented Sep 8, 2021

Yeah, I agree - in my comment re #14 i stated it so, that there should be a question first. maybe one could set a config item to suppress it permanently or a command line switch to suppress it for the current execution.

@muesli muesli added the enhancement New feature or request label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants