Implementations seem inefficient.

[RobertZenz]

Most implementations seem a little bit inefficient, for example the Java version could be optimized to this:

class yes {
    public static void main (String[] args) {
        if (args.length == 0) {
            while (true) {
                System.out.println("y");
            }
        } else {
            String line = "";
            for (String arg : args) {
                line = line + arg + " ";
            }
            line = line.substring(0, line.length() - 1);
            
            while (true) {
                System.out.println(line);
            }
        }
    }
}

We first build the string which will be one line, and then simply dump that string into the output stream. This removes the need for the system to constantly parse "%s ", it also removes that trailing space from each line which shouldn't be there.

As a sidenote, yes, I could have used a StringBuilder, but opted against it for simplicity reasons and simply because the string, hopefully, never becomes that large to warrant a StringBuilder there.

The same applies to the C, Go, PHP, Python versions, and to a lesser extend to nearly all other versions, which are constantly looping over the arguments instead of caching the line once.

[TheBinaryFox]

The optimized Java version could be further simplified:

class yes {
    public static void main (String[] args) {
        if (args.length == 0) {
            while (true) {
                System.out.println("y");
            }
        } else {
            String line = args[0];
            for (int i = 1; i < args.length; i++) {
                line = line + " " + args[i];
            }
            
            while (true) {
                System.out.println(line);
            }
        }
    }
}

Or for Java 8:

class yes {
    public static void main (String[] args) {
        if (args.length == 0) {
            while (true) {
                System.out.println("y");
            }
        } else {
            String line = String.join(" ", args);
            while (true) {
                System.out.println(line);
            }
        }
    }
}

[mubaris]

Thanks for the suggestion @RobertZenz . I will work on that 👍

[RobertZenz]

@TheBinaryFox Thanks, from time to time I forget about the new methods.

@mubaris While looking at it again, the class should be called Yes according to the Java naming conventions. Also, in the "standard" there is no space between function names and the parentheses. But that's overruled by personal preference.

And looking at it again (thinking isn't exactly my strong skill past midnight), you could do something like this:

String output = "y";

if (args.length > 0) {
    output = String.join(" ", args); // Or any other string concatenation.
}

while (true) {
    System.out.println(output);
}

[mubaris]

@RobertZenz I like the latest version. This is concise.

[ladydascalie]

@RobertZenz I've PR'd two potential improvements for the PHP and Go version, you are more than welcome to have a look at

[mubaris]

@RobertZenz I have implemented the efficient version in Java 8. Thanks to you and @TheBinaryFox . And about naming conventions, I thought about standard naming convention when I wrote the code for the first time. And I decided to use yes instead of Yes, because that's the command name.

[RobertZenz]

@ladydascalie Never read Go before, but looks good. Except the indentation of the PHP version is fucked up (there are also two spaces after the equals sign).

[ladydascalie]

PR #24 adds an even better go implementation eliminating duplicate for loops and using a switch to be more concise / readable, I'll correct that PHP indentation issue as well

[RobertZenz]

@ladydascalie Why use a switch if there are only two cases?

[ladydascalie]

@RobertZenz agreed, if you check my pr for the go version, I removed that, I hadn't done it on the PHP one though. I've just done that now however 👍

[maferland]

I thought I could improve the python version. I removed a useless ; and the else statement achieved nothing. #88

[Scan0r]

@TheBinaryFox Thanks, from time to time I forget about the new methods.

@mubaris While looking at it again, the class should be called Yes according to the Java naming conventions. Also, in the "standard" there is no space between function names and the parentheses. But that's overruled by personal preference.

And looking at it again (thinking isn't exactly my strong skill past midnight), you could do something like this:

String output = "y";

if (args.length > 0) {
    output = String.join(" ", args); // Or any other string concatenation.
}

while (true) {
    System.out.println(output);
}

Improving it even more you could write:

String output = args.length > 0 ? String.join(" ", args) : "yes";
while(true)
System.out.println(output);

[RobertZenz]

@Scan0r That's not improved, that's just shorter (and not in the more readable way I might argue).