Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of Preview button for custom games not too helpful #258

Open
redactedscribe opened this issue Aug 22, 2023 · 2 comments
Open

Purpose of Preview button for custom games not too helpful #258

redactedscribe opened this issue Aug 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@redactedscribe
Copy link

Ludusavi version

v0.21.0

Operating system

Windows

Installation method

Scoop

Description

Clicking Preview for a custom game doesn't really preview anything. If even only one entry is valid, we get "Save data found.", but if all are invalid, we get "No save data found.". To me this is more of a Validate button than a preview button in its current state. When disabling a custom game and then clicking Preview, no feedback is given at all.

I'm not sure if this footer line of info is a bug because I don't recall this button's behaviour from the previous version (I would've thought Preview would have at least shown a pop-up or something with all the items the defined paths contain, or maybe tick marks / crossed beside each path to indicate validity).

Thanks.

Logs

No response

@redactedscribe redactedscribe added the bug Something isn't working label Aug 22, 2023
@mtkennerly
Copy link
Owner

There's definitely some room to improve the UX on this. It does generate a preview, but it's shown on the backup tab. Part of the idea is that you can add a custom game and use its scan button so it shows up in the main list without having to do a full scan just to make it show up. Displaying the results in a modal would probably be a good improvement.

When disabling a custom game and then clicking Preview, no feedback is given at all.

Good catch! That part is definitely a bug.

@redactedscribe
Copy link
Author

redactedscribe commented Aug 22, 2023

Part of the idea is that you can add a custom game and use its scan button so it shows up in the main list without having to do a full scan just to make it show up.

Ah, yes. I remember reading or discussing something about this. It's not clear that this is happening though, so perhaps Preview should jump to the game entry in Backup Mode tab? I think that would be the most common case for pressing Preview since that's its purpose. Then a modifier key could be used for Preview to preview without jumping to the Backup Mode tab (if wanting to click Preview on several custom games). Just a thought.

Displaying the results in a modal would probably be a good improvement.

This wouldn't be needed with what I've just outlined, but perhaps there's a good reason to see the results on the Custom Games tab, I don't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants