do not reset handlers if msw is not defined for story, fix #25 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mswjs/msw-storybook-addon/GM8Hxc57cmqR4LdARhQMh5n7dy4f |
|
Turns out this was not the root cause in the end, but rather a conflicting storybook addon. |
|
@gazs which storybook addon was conflicting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Ensuring that api.resetHandlers() is only called if msw is defined as a parameter of a story solves the issue where if any loaded story file didn't have an msw parameter defined the browser window would hang.
While this solves the issue in my storybook, I am not sure if it can have any unintended effects, please let me know!