-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the npm package files #572
Comments
Hi, @tkrotoff. Thanks for raising this. What chunk format would you consider more friendly? Note, these are automatically generated by If you can tell me more about the issue you've experienced, the way you tried to debug, and the way that actually worked, that would help me in making the right decision here. Thanks. |
No chunks
I've never used tsup nor needed it for my libraries, maybe it's not a great tool, maybe you don't need it. For example, you don't need to ship the .map files (source maps): you don't need to minify the code and Node.js knows recent ES features so the original code and the bundled code are almost identical.
You have a performance issue (https://github.com/tkrotoff/jsdom-slow-URL-parsing). |
That's now how ESM works. Your test will end up importing everything and evaluating everything, which will make it slow. Not to mention there are parts of this library meant only for Node.js, while others are meant for Node.js/browser (mixed) environments.
Sounds like you have a familiarity bias then. I've been using tsup for years, and now plenty of projects that do the same. Perhaps you never happened to ship libraries in the formats I need to ship them.
If URL paring is slow in , that is no shape or form an issue with this library. I don't see how this is relevant here. ConslusionThis library has no issues with the files it ships to npm. They are unminified, CJS/ESM, sourcemapped, and code splitting-friendly. They also are split in the manner that makes sense in the context of how this package is meant to be consumed. |
The generated npm package contains files that are randomly named like chunk-GUY7XK43.mjs. Please make the npm package files human friendly.
This makes the source code difficult to debug (in the context of an application that uses @mswjs/interceptors via node_modules).
I had a hard time finding a performance issue with JSDOM because of this: https://github.com/tkrotoff/jsdom-slow-URL-parsing
The text was updated successfully, but these errors were encountered: