Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APK issues #18

Open
IzzySoft opened this issue Jun 13, 2024 · 5 comments
Open

APK issues #18

IzzySoft opened this issue Jun 13, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@IzzySoft
Copy link

There are a few issues with the FOSS APKs attached to your releases:

  • release is tagged 1.2.5 and not the first one, yet the APK announces itself as versionCode='1' versionName='0.0.1'. versionCode must be increased with each release (as that's what Android uses internally to tell versions apart) – so as this is not the first release, the integer assigned there should be higher. And versionName should match what the tag claims it to be, here: 1.2.5
  • the APK requests several permissions not outlined in the description. E.g. it requests INTERNET though the description says "offline", it declares android.permission.RECORD_AUDIO but the description does not mention audio recording (it suggests its a note-taking app), it requests android.permission.RECEIVE_BOOT_COMPLETED and android.permission.FOREGROUND_SERVICE though there's no hint on why those should be needed. The screenshots give no clue either. Could you please clarify?
  • there's no icon in the fastlane tree – so the app will turn up without any at F-Droid (XML icons cannot be extracted there). You might wish to add one 😉
  • your short description in fastlane has a spelling error in its name, so it won't be pulled. Don't shoot the messenger please, it was you who named it shot_description.txt and missing the r 🙈

I've just added your app to the IzzyOnDroid repo (it will show up here with the next sync around 6 pm UTC), and included an icon manually (taken from your Readme) as well as copied the "shot" description giving it the correct name – so be welcome to pick a badge to link there from your Readme. It would be nice to have above issues solved with the next release, though, so I can also enable automated updates here and your listing at F-Droid.org will work out, too 😉

For a "sneak preview":

image
image

@mshdabiola
Copy link
Owner

i will remove it later, thanks

@IzzySoft
Copy link
Author

Remove what?

@mshdabiola
Copy link
Owner

The Internet permission

@IzzySoft
Copy link
Author

Ah, thanks! Any plans for the other points listed above?

@mshdabiola mshdabiola added enhancement New feature or request and removed enhancement New feature or request labels Jul 7, 2024
@IzzySoft
Copy link
Author

Ah, I see you have the versioning fixed – great! So I've just enabled updates (the latest release should show up with the next sync around 6 pm UTC then). RECORD_AUDIO now is also explained in the readme (audio notes). Now I only miss the IzzyOnDroid badge in your Readme, as your app is listed there for over a month already 😉 With that added, I guess this issue can be closed then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants