-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valgrind #173
Comments
3 tasks
Noting this should be fixed - in the next release. 0.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Thanks for this handy library! I've already found a fix for this issue, but would prefer not to have to fork the project. If I can be allowed to push a feature branch to this repo, I'd be happy to share my fix. I don't know what kind of changes (if any) would be needed to the test suite, and unfortunately I don't have the time to figure that out. The fix is simply as follows, in
include/restclient-cpp/connection.h:267
:Expected behaviour
no memory leaks in
valgrind
Actual behaviour
Relevant part of
valgrind
output:Environment and debugging details
g++ (GCC) 8.3.0
Ubuntu 18.04.4 LTS
0.5.2
(commit IDb782bd2
)git clone
, thencmake -D BUILD_SHARED_LIBS=OFF -D CMAKE_CXX_FLAGS="-g -fPIC" ..
+make
(I include this as a static lib in another shared lib that I build later)The text was updated successfully, but these errors were encountered: