Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website demo video doesn't play in Chrome #40

Open
HaleTom opened this issue Oct 13, 2018 · 6 comments
Open

Website demo video doesn't play in Chrome #40

HaleTom opened this issue Oct 13, 2018 · 6 comments

Comments

@HaleTom
Copy link

HaleTom commented Oct 13, 2018

On my laptop and phone, the demo at https://mroth.github.io/scmpuff/ does not play.

Does this support ls file shortcuts, like scm_breeze does?

@HaleTom HaleTom changed the title Demo video - does this support ls shortcuts? Demo video doesn't play - does this support ls shortcuts? Oct 13, 2018
@mroth
Copy link
Owner

mroth commented Oct 19, 2018

Hi @HaleTom -- what browser/OS for laptop/phone is this happening in?

@HaleTom
Copy link
Author

HaleTom commented Oct 20, 2018

Latest Chrome on Android is one.

Latest Chrome on Arch Linux is the other.

@mroth
Copy link
Owner

mroth commented Dec 28, 2018

I can reproduce the website issue in Chrome on macOS. It looks like Chrome must have changed something about how video autostart functions.

Does this support ls file shortcuts, like scm_breeze does?

By design, by default we do not wrap any shell comments other than git. I consider wrapping cd, ls and/or other critical navigation commands to be too risky. You can wrap them yourself to use scmpuff expand if you desire though, see #41 for some ideas.

@mroth mroth changed the title Demo video doesn't play - does this support ls shortcuts? Website demo video doesn't play in Chrome Dec 28, 2018
@mroth
Copy link
Owner

mroth commented Dec 28, 2018

@mroth
Copy link
Owner

mroth commented May 23, 2019

I think the best approach for a variety of reasons would be to replace this entirely with an animated SVG, like I have on https://github.com/mroth/bump.

These are relatively easy to make now, but I would need to re-record the demo. (If someone wants to replicate the demo and record it for me, let me know and I can provide you with the steps!)

@gucheen
Copy link

gucheen commented Sep 27, 2020

@mroth add the controls attribute to video tag in index.html to show video controllers.
Maybe it's a good temporary solution.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants