-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scmpuff status: migrate hardcoded ANSI color codes to a cross-platform color library #28
Comments
I actually used something really simple for the It only took changing from |
Maybe we could just use git's internals for this? Would allow configuration as well (we'd have to provide default colors though which we probably have to pull out of the git codebase):
From
Would probably also fix #9 |
This will improve cross-platform support for future shells, and also hopefully allow the code to become more clean and understandable. As @stereokai showed in #14, currently Windows in PowerShell does not properly render the ANSI escape codes as color.
There is likely a strong chance to refactor and clean up the UI formatting code with this too, which is worth being opportunistic with if it presents itself.
Some of the color libraries seem to have the built in ability to disable color output entirely in a convenient way without branching all the UI code (fatih/color), which could be a nice command line switch to add to
scmpuff status
if easy enough to do cleanly.The text was updated successfully, but these errors were encountered: