-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude the base directory when is a symlink and the followSymbolicLinks option is disabled #300
Comments
@mrmlnc Can I help you to fix it? |
After a few approaches, I think it's not a bug, but an inaccuracy in the documentation. But we can change this behavior in the future. When the directory structure has the following form and the
Here we have a base directory ( In the other case, when two patterns ( To me, it looks like right now we should fix the documentation based on the
Then I looked at the behavior of # rg '' --no-follow -g '**' .
directory/file.txt
# rg '' --no-follow -g '**' directory symlink
directory/file.txt
symlink/file.txt
# rg '' --no-follow -g '{directory,symlink}/**' .
directory/file.txt The current architecture makes it difficult to implement this behavior. We must stop using the base directory as Right now, I'll fix the documentation and mark this issue as feature request. Unfortunately now you have to consider adding filtering on your side. |
Environment
Actual behavior
My structure:
Running code sample I get:
If I create new symlink inside
dir
orsymlink
, it will be ignored as expected, but when I put path to symlink as an argument tofast-glob
followSymbolicLinks
is ignoredExpected behavior
Steps to reproduce
Code sample
The text was updated successfully, but these errors were encountered: