Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection for assigning Color/Brush resources correctly #501

Open
mrlacey opened this issue Nov 23, 2021 · 0 comments
Open

Add detection for assigning Color/Brush resources correctly #501

mrlacey opened this issue Nov 23, 2021 · 0 comments
Labels
Styles Xamain.Forms Relates to XAML in Xamarin.Forms projects XAML-Analysis Relates to XAML Analysis functionality
Milestone

Comments

@mrlacey
Copy link
Owner

mrlacey commented Nov 23, 2021

Currently, when a color resource is assigned to a property that takes a brush it is silently ignored.
The same is true for assigning a brush to a color.

This can lead to things not being drawn as expected at runtime and they can be hard to spot/debug.

Reproduce by creating a color resource and assigning it to a Fill or a SolidColorBrush resource and assigning it to a color.

Will need knowledge of styles to be able to do this. (So possibly a post-1.0 task)

Verified with Xamarin.Forms on VS2019 but need to check to see what else is affected.

@mrlacey mrlacey added XAML-Analysis Relates to XAML Analysis functionality Xamain.Forms Relates to XAML in Xamarin.Forms projects Styles labels Nov 23, 2021
@mrlacey mrlacey added this to the Backlog milestone Nov 23, 2021
@mrlacey mrlacey changed the title Add detection for assigning Color/Brush correctly Add detection for assigning Color/Brush resources correctly Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styles Xamain.Forms Relates to XAML in Xamarin.Forms projects XAML-Analysis Relates to XAML Analysis functionality
Projects
None yet
Development

No branches or pull requests

1 participant