You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Probably we should extract some logic from it and also somehow refactor initialize method.
From beginning there was also Tank class and Robot was composed from Ai, Tank and Command parser. But as soon as I started to adding functionality Tank and Robot became really entangled with a lot of duplication... I did not like it so I've merged Tank into the Robot.
But right now Robot is really big so it needs to be refactored somehow.
Any ideas?
The text was updated successfully, but these errors were encountered:
First thing that comes to my mind is splitting "robot devices" into separate classes (e.g Radar, Gun)
Xmas was a hard time for me to look at the codebase, unless you're already working on it, I would love to take care of this as a chance to get in touch with the code while refactoring it
Robot
class is really growing. And I do not like it.https://github.com/mrhead/ruby_arena/blob/master/lib/robot.rb # right now, it is 198 LOC
Probably we should extract some logic from it and also somehow refactor
initialize
method.From beginning there was also
Tank
class andRobot
was composed fromAi
,Tank
andCommand
parser. But as soon as I started to adding functionalityTank
andRobot
became really entangled with a lot of duplication... I did not like it so I've mergedTank
into theRobot
.But right now
Robot
is really big so it needs to be refactored somehow.Any ideas?
The text was updated successfully, but these errors were encountered: