Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBTN_LEFT cycle pause] causes video pausing when double-click (fullscreen toggle) #685

Open
Mark-Joy opened this issue May 12, 2024 · 9 comments
Assignees
Labels

Comments

@Mark-Joy
Copy link

Mark-Joy commented May 12, 2024

With [MBTN_LEFT cycle pause] or [MBTN_LEFT script-message-to mpvnet play-pause] in input.conf, video is cycle paused when left-mouse double-clicking (fullscreen toggle).

This can't be reproduced with mpv. In other words, this works as expected in mpv: left-mouse double-click only toggles fullscreen, and not causing video to pause/unpause.

Additional context
Add any other context about the problem here.

  1. mpv.net version: v7.1.1.0
  2. mpv version: 0.38.0
  3. Windows version: Windows 10

May relating to #89

@Sneakpeakcss
Copy link
Collaborator

Try putting input-doubleclick-time=1 in mpv.conf and see if that fixes it for you.

@Mark-Joy
Copy link
Author

input-doubleclick-time=1

It still causes video to cycle pause.
Note that the fullscreen toggle feature works perfectly in original post even without input-doubleclick-time=1. It just that, after the fullscreen is toggled, the pausing is toggled as well.

@Sneakpeakcss
Copy link
Collaborator

I'm confused what's exactly the issue here.

By default mpv.net v7 doesn't bind anything under MBTN_LEFT and uses
MBTN_LEFT ignore same as default mpv config. When MBTN_LEFT cycle pause is used in mpv then it has the same behaviour of cycling pause/play during doubleclick (fullscreen).

@Mark-Joy
Copy link
Author

Mark-Joy commented May 12, 2024

By default mpv.net v7 doesn't bind anything under MBTN_LEFT

new ("", "", "ignore", "MBTN_Left", _("Ignore left mouse butten")),

MBTN_LEFT is bind with ignore by default in mpv.net. In mpv, it isn't bind by anything by default.
And the only line in my input.conf is MBTN_LEFT cycle pause, for both mpv.net and mpv

@Sneakpeakcss
Copy link
Collaborator

(...) and uses MBTN_LEFT ignore same as default mpv config.

MBTN_LEFT is bind with ignore by default in mpv.net. In mpv, it isn't bind by anything by default.

options-input-default-bindings / input-builtin-bindings

input.conf

image

What you're describing is literally default mpv behaviour, and using MBTN_LEFT cycle pause with a clean install of mpv behaves the same as you mentioned:

test.mp4

@Mark-Joy
Copy link
Author

Ok. Let me explain in a bit more details:
Suppose the video was in pause state before left-mouse double-clicking

  • In mpv: after double-clicking, the video is still on pause state
  • In mpv.net: after double-clicking, the video is changed to play state

Suppose the video was in play state before left-mouse double-clicking

  • In mpv: after double-clicking, the video is still on play state
  • In mpv.net: after double-clicking, the video is changed to pause state

In other words, in mpv the play/pause state is not changed after double-clicking. While in mpv.net the play/pause state is toggle after double-clicking

@Sneakpeakcss
Copy link
Collaborator

Sneakpeakcss commented May 12, 2024

Ok. Let me explain in a bit more details: Suppose the video was in pause state before left-mouse double-clicking

* In `mpv`: after double-clicking, the video is still on **`pause`** state

* In `mpv.net`: after double-clicking, the video is changed to **`play`** state

Suppose the video was in play state before left-mouse double-clicking

* In `mpv`: after double-clicking, the video is still on **`play`** state

* In `mpv.net`: after double-clicking, the video is changed to **`pause`** state

In other words, in mpv the play/pause state is not changed after double-clicking. While in mpv.net the play/pause state is toggle after double-clicking

This sounds like it's related to this then, and from the response in that issue it probably won't get fixed anytime soon.

[edit]
Yea, most certainly related to the same issue:

MBTN_Left script-message-to console type "print-text 'MBTN_Left'" ; keypress ENTER
MBTN_Left_dbl script-message-to console type "print-text 'MBTN_Left_dbl'" ; keypress ENTER

image

@Mark-Joy
Copy link
Author

new ("", "", "ignore", "MBTN_Left", _("Ignore left mouse butten")),

Well, I suppose there's no good reason for why the above code should be there. I mean, it is hard coded and furthermore it is bound to ignore

@wooshaq
Copy link

wooshaq commented May 13, 2024

How does net changes mouse to regular mpv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants