Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f_decoder_wrapper: clear decoder info on deinit #14053

Merged
merged 1 commit into from May 4, 2024

Conversation

kasper93
Copy link
Contributor

@kasper93 kasper93 commented May 3, 2024

It is not longer valid and may cause use-after-free if used after decoder itself is destroyed.

Fixes: #14051

It is not longer valid and may cause use-after-free if used after
decoder itself is destroyed.

Fixes: mpv-player#14051
Copy link

github-actions bot commented May 3, 2024

Download the artifacts for this pull request:

Windows
macOS

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. I didn't see an obvious fix yesterday or I would have done it myself :)

@sfan5 sfan5 merged commit 637bc69 into mpv-player:master May 4, 2024
15 checks passed
@kasper93 kasper93 deleted the dec_wrap branch May 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UaF when video output fails to initialize
2 participants