Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPEG screenshots taken with vo=gpu-next appear darker than when taken with vo=gpu #13995

Open
raziel711 opened this issue Apr 25, 2024 · 2 comments

Comments

@raziel711
Copy link

Important Information

Provide following Information:

Reproduction steps

This is a JPEG screenshot taken by mpv --no-config using the screenshot command:
gpu

This is a screenshot taken by mpv --no-config --vo=gpu-next:
gpu-next

The JPEG screenshot taken when using gpu-next appears slightly darker, particularly around the stalactites, than the screenshot taken when using gpu. I'm not sure if screenshot-tag-colorspace affects JPEG screenshots, but just to rule it out, setting --screenshot-tag-colorspace=no does not have any impact.

Expected behavior

JPEG screenshots should have the same brightness.

Actual behavior

There is a difference in brightness between gpu-next and gpu.

Log file

log.txt

Sample files

Any video file should work, but it is easiest to see the difference when taking screenshots with scenes that are set in low light.

@sfan5
Copy link
Member

sfan5 commented Apr 26, 2024

Can't reproduce with a 10-bit source video.
Can reproduce with a 8-bit source video. Also confirmed that it doesn't affect the rendered result, but only screenshots.

Sounds like it could be an issue with limited/full range YUV, in the vo_gpu_next code or libplacebo. Screenshots pulled from the GPU are already RGB so the image writer is not at fault.

@Traneptora
Copy link
Member

With --screenshot-tag-colorspace=no the image will be coerced into sRGB before saving. If I had to guess, this is likely because libplacebo does black point compensation but the native color shaders do not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants