Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix track selection #13917

Merged
merged 5 commits into from May 9, 2024
Merged

Fix track selection #13917

merged 5 commits into from May 9, 2024

Conversation

kasper93
Copy link
Contributor

@kasper93 kasper93 commented Apr 17, 2024 •
edited

Fixes #13983

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited

Download the artifacts for this pull request:

Windows
macOS

@kasper93 kasper93 closed this Apr 17, 2024
@kasper93 kasper93 reopened this Apr 17, 2024
@kasper93 kasper93 marked this pull request as draft April 17, 2024 18:32
@sfan5
Copy link
Member

sfan5 commented Apr 17, 2024

👎 for removing the language matching. Being able to specify slang=en and have it transparently match eng is an improvement.

@kasper93
Copy link
Contributor Author

👎 for removing the language matching. Being able to specify slang=en and have it transparently match eng is an improvement.

It's a draft.

@kasper93 kasper93 marked this pull request as ready for review April 17, 2024 19:26
@kasper93
Copy link
Contributor Author

Now it is ready.

@kasper93 kasper93 force-pushed the sub_select branch 7 times, most recently from 89e2f36 to 7874593 Compare April 17, 2024 21:12
@guidocella guidocella mentioned this pull request Apr 18, 2024
Merged
@kasper93 kasper93 added this to the Release v0.39.0 milestone Apr 18, 2024
@kasper93 kasper93 mentioned this pull request Apr 24, 2024
Closed
@sfan5 sfan5 self-requested a review May 3, 2024 15:13
sfan5
sfan5 reviewed May 6, 2024
View reviewed changes
misc/language.c Outdated Show resolved Hide resolved
misc/language.c Show resolved Hide resolved
test/language.c Show resolved Hide resolved
DOCS/man/options.rst Outdated Show resolved Hide resolved
misc/language.c Outdated Show resolved Hide resolved
@kasper93 kasper93 force-pushed the sub_select branch 4 times, most recently from b72f414 to 1d58350 Compare May 6, 2024 23:50
@kasper93 kasper93 requested review from sfan5 and guidocella May 6, 2024 23:52
guidocella
guidocella approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@guidocella guidocella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works.

@kasper93
Copy link
Contributor Author

kasper93 commented May 7, 2024

Pushed small optimization for language table.

sfan5
sfan5 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sfan5
Copy link
Member

sfan5 commented May 9, 2024

one last thing: shouldn't Revert "misc: add language-matching utilities" be the last of the revert commits? Otherwise mpv won't compile if I check out one of the revisions in between.

@kasper93
Copy link
Contributor Author

kasper93 commented May 9, 2024

one last thing: shouldn't Revert "misc: add language-matching utilities" be the last of the revert commits? Otherwise mpv won't compile if I check out one of the revisions in between.

Good point, reordered.

@kasper93 kasper93 merged commit 4fe6793 into mpv-player:master May 9, 2024
18 checks passed
@kasper93 kasper93 deleted the sub_select branch May 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@guidocella guidocella guidocella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v0.39.0
Development

Successfully merging this pull request may close these issues.

--slang region doesn't work
3 participants
@kasper93 @sfan5 @guidocella