Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support built-in command palette script/API (a searchable menu) #13964

Closed
stax76 opened this issue Apr 22, 2024 · 2 comments · Fixed by #13982 or #14087
Closed

Support built-in command palette script/API (a searchable menu) #13964

stax76 opened this issue Apr 22, 2024 · 2 comments · Fixed by #13982 or #14087
Labels
meta:feature-request

Comments

@stax76
Copy link
Contributor

stax76 commented Apr 22, 2024

Expected behavior of the wanted feature

I noticed there has been work done on a context menu, there is another popular UI concept that could be supported as built-in script and API, a searchable menu, it can be used for:

Bindings, playlist, chapters, profiles, audio/subtitle/video tracks, commands, properties, options, audio devices, recent files, console history and more. mpv having such features built-in would improve productivity and user-friendliness, especially for beginners, some user scripts are hard to find and difficult to install due to lack of good documentation and missing package/extension/script manager.

The UI concept is very useful and popular, used for many things in VS Code (158k GitHub stars) and fzf (59k GitHub stars).

The same or similar concept is in the start menu of Windows, Gnome and KDE, in browser address bars and popular external launchers:

alfred launcher for macOS
flow launcher for Windows
rofi and albert launcher for Linux.

mpv.net had a WPF based command palette, but the code stopped working after porting from .NET Framework to .NET 5 (Core) due to a change made by Microsoft. Some mpv.net users miss the lost functionality now.

The existing script, 500 lines of code:

https://github.com/stax76/mpv-scripts?tab=readme-ov-file#command_palette

It's based on an awesome module which has 900 lines of code, found here:

https://github.com/Seme4eg/mpv-scripts/blob/master/script-modules/extended-menu.lua

There are a couple of searchable mpv menus listed here:

https://github.com/stax76/awesome-mpv?tab=readme-ov-file#menu
@guidocella
Copy link
Contributor

I implemented this in https://github.com/guidocella/mpv-console-select with just mp.input and the console's log instead of making a custom UI. I'm not sure if we want to upstream something like it.

@tsl0922
Copy link
Contributor

tsl0922 commented Apr 24, 2024

The context menu may have a libass based fallback implementation in the feature, it should be possible to adapt it to behave like command palette.

guidocella added a commit to guidocella/mpv that referenced this issue Apr 24, 2024
@guidocella
scripting: add mp.input.select()
5b87b2d 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
@guidocella guidocella mentioned this issue Apr 24, 2024
Merged
guidocella added a commit to guidocella/mpv that referenced this issue Apr 24, 2024
@guidocella
scripting: add mp.input.select()
35e25a3 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue Apr 24, 2024
@guidocella
scripting: add mp.input.select()
dde2c43 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue Apr 24, 2024
@guidocella
scripting: add mp.input.select()
2e95607 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue Apr 25, 2024
@guidocella
scripting: add mp.input.select()
5f68965 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue Apr 26, 2024
@guidocella
scripting: add mp.input.select()
ecc1cfe 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue Apr 26, 2024
@guidocella
scripting: add mp.input.select()
47a40fa 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 4, 2024
@guidocella
scripting: add mp.input.select()
b6acab5 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes mpv-player#13964.
kasper93 pushed a commit that referenced this issue May 7, 2024
@guidocella @kasper93
scripting: add mp.input.select()
2354d87 
This allows scripts to make the user choose from a list of entries by
typing part of their text and/or by navigating them with keybindings,
like dmenu or fzf.

Closes #13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 8, 2024
@guidocella
select.lua: add this script
ad4699c 
This adds script messages to select playlist entries, tracks, chapters
and subtitle lines using the newly introduced mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 8, 2024
@guidocella
select.lua: add this script
dadd968 
This adds script messages to select playlist entries, tracks, chapters
and subtitle lines using the newly introduced mp.input.select().

This fully closes mpv-player#13964.
@guidocella guidocella mentioned this issue May 8, 2024
Merged
guidocella added a commit to guidocella/mpv that referenced this issue May 9, 2024
@guidocella
select.lua: add this script
8dc83d8 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 9, 2024
@guidocella
select.lua: add this script
a7ab0f8 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 9, 2024
@guidocella
select.lua: add this script
5e6de1a 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
fdad055 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
d490e7e 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
78d7192 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
a37b406 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
d71eb63 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 10, 2024
@guidocella
select.lua: add this script
c06650b 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
be00189 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
541392d 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
4212d6d 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
f419c40 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
9399686 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
582a9c9 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
559e818 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 11, 2024
@guidocella
select.lua: add this script
fec0c91 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
34e2d0e 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
0f49ffc 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
838cd3e 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
fb99889 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
80f3bfe 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
1cd542f 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
538e728 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
guidocella added a commit to guidocella/mpv that referenced this issue May 12, 2024
@guidocella
select.lua: add this script
7e10317 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes mpv-player#13964.
kasper93 pushed a commit that referenced this issue May 12, 2024
@guidocella @kasper93
select.lua: add this script
61f72bd 
This adds script messages to select playlist entries, tracks, chapters,
subtitle lines, bindings and properties using the newly introduced
mp.input.select().

This fully closes #13964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scripting: add mp.input.select() guidocella/mpv
select.lua: add this script guidocella/mpv
3 participants
@tsl0922 @stax76 @guidocella