Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track-list is incorrectly detecting the video track as an image in some videos #13975

Closed
raziel711 opened this issue Apr 23, 2024 · 1 comment · Fixed by #14065
Closed

track-list is incorrectly detecting the video track as an image in some videos #13975

raziel711 opened this issue Apr 23, 2024 · 1 comment · Fixed by #14065
Assignees
@kasper93

Comments

@raziel711
Copy link

Important Information

Provide following Information:

I am having an issue that with some videos, track-list/N/image is incorrectly reporting the video track as an image starting with shinchiro's mpv v0.37.0-241-gfe0c181b build. This isn't happening with every video so I'm including a sample video.

sample.zip

Reproduction steps

Starting with the v0.37.0-241-gfe0c181b build through the current build, playing the sample video by mpv --no-config sample.mkv and entering show-text ${track-list/0/image} in the console gives:
mpv v0 37 0-241-gfe0c181b

However, with the previously available build, mpv v0.37.0-229-gc6ccabe5, show-text ${track-list/0/image} gives the correct value:
mpv v0 37 0-229-gc6ccabe5

Expected behavior

track-list/N/image should be no for video tracks.

Actual behavior

track-list/N/image is yes on video tracks for certain videos.

Log file

log.txt
@kasper93 kasper93 self-assigned this Apr 23, 2024
@kasper93
Copy link
Contributor

I have a fix for that, will push when I have time.

kasper93 added a commit to kasper93/mpv that referenced this issue May 5, 2024
@kasper93
demux_mkv: fix image detection
4f92259 
If blocks were already demuxed we would skip them and ask for new ones.
For files with few blocks it would return EOF without actually checking
the content.

Also make demux limit higher. In practice it doesn't matter, because if
it is image, video track will have only 1 block. And if it is not image
it will break on 2nd video block. Depending on the mux interlave we just
need to skip to first blocks of video track.

Fixes: mpv-player#13975
kasper93 added a commit to kasper93/mpv that referenced this issue May 5, 2024
@kasper93
demux_mkv: fix image detection
8e0e97b 
If blocks were already demuxed we would skip them and ask for new ones.
For files with few blocks it would return EOF without actually checking
the content.

Also make demux limit higher. In practice it doesn't matter, because if
it is image, video track will have only 1 block. And if it is not image
it will break on 2nd video block.

Fixes: mpv-player#13975
@kasper93 kasper93 mentioned this issue May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasper93 kasper93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

demux_mkv: fix image detection kasper93/mpv
2 participants
@kasper93 @raziel711