Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of movementX/Y to MouseEvent #29

Open
pro100filipp opened this issue Jun 19, 2023 · 7 comments
Open

Addition of movementX/Y to MouseEvent #29

pro100filipp opened this issue Jun 19, 2023 · 7 comments

Comments

@pro100filipp
Copy link

According to official docs, movementX/Y is well-supported both by Safari and iOS. If you don't mind, I'd like to make a PR adding it.

@mpizenberg
Copy link
Owner

mpizenberg commented Jun 19, 2023

Hum, according to the docs, it’s well supported for quite some time (2015), roughly the same as FF and chrome. And I started this library around 2017. So I suspect there was still something not working well with movementX/Y ... (but I don’t remember what, maybe related to "pointer" events?)
Would you mind being extra precautious with testing it’s behaving the same in different OS?
Then the PR is welcome of course!

@pro100filipp
Copy link
Author

Yes, that also seemed strange to me. I'll do some investigation and tell about results. Hope in 2023 it'll "just work" though :)

@pro100filipp
Copy link
Author

Unfortunately, mobile Safari PointerEvent really does not have movementX/Y. I also did some testing on Chrome, Brave and FF – none of them had movementX/Y too. MDN standard looks like a fucking joke – even in 2023.

The issue can be closed I think, sorry for the disturbance(

@mpizenberg
Copy link
Owner

Thanks for checking

@mpizenberg
Copy link
Owner

Also, as I often say to other people with specific requests, this package is convenient for quick prototyping, but don’t hesitate to extract the functions and decoder you need instead of depending on the package.

@pro100filipp
Copy link
Author

Of course – and thank you for the convenient API made for this) Just thought it'd be a good candidate for a standard functionality

@mpizenberg
Copy link
Owner

Note to self (or anyone willing to do a docs PR): better explain that movementX/Y are not in because the support for pointer events is not good, and we are reusing the same decoder for mouse events and pointer events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants