Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce a max number of channels (subscriptions) per user #733

Open
data-sync-user opened this issue Jul 18, 2024 · 2 comments
Open

Enforce a max number of channels (subscriptions) per user #733

data-sync-user opened this issue Jul 18, 2024 · 2 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jul 18, 2024

https://mozilla-hub.atlassian.net/browse/SYNC-4221 will begin updating TTL records for every entry in the router column family so we can enable Bigtable’s garbage collection of router data. Under Bigtable, when updating the TTL (when a user conducts some form of activity) we need to first read the contents of that router row, then write the contents out again with new TTLs (cell timestamps).

We currently do not enforce any kind of limit of the number of channels (subscriptions) a user can have. Especially with the added work of needing to read all the channels out and then write them again with the new timestamp, we should begin enforcing some kind of maximum limit of channels to limit the work required. Also any user exceeding such a limit is likely either misconfigured or abusing our system.

The enforcement of the max should simply drop the user record, forcing them to recreate a fresh one.

┆Issue is synchronized with this Jira Task

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

What should be the maximum? 100? 1000?

@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

Hrm. We could probably add a metric to the mobile channel check and the desktop “hello” to get an idea of the median number of channels a given UAID may have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant