Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fsnotify to detect model/policy files change in casbin plugin #556

Open
spacewander opened this issue May 28, 2024 · 2 comments · May be fixed by #614
Open

Use fsnotify to detect model/policy files change in casbin plugin #556

spacewander opened this issue May 28, 2024 · 2 comments · May be fixed by #614
Assignees
@lyt122
Labels
good first issue Good for newcomers plugins hub

Comments

@spacewander
Copy link
Member

Description

No response

Use Scenes

Currently, we use 30s polling to detect the file changes. This way is cumbersome and not up-to-date.

Advice

See https://github.com/fsnotify/fsnotify
@spacewander
Copy link
Member Author

The brave who wants to solve this can start from

htnn/plugins/plugins/casbin/filter.go

Line 43 in 1773293

policyChanged := file.IsChanged(conf.modelFile, conf.policyFile)

@lyt122
Copy link
Contributor

lyt122 commented Jun 5, 2024

plz assign this issue to me

@lyt122 lyt122 linked a pull request Jun 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyt122 lyt122

Labels
good first issue Good for newcomers plugins hub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP]feat: Use fsnotify to detect model/policy files change in casbin plugin lyt122/htnn
2 participants
@spacewander @lyt122