Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing string as error to callback #8

Open
tacticalchihuahua opened this issue Aug 25, 2016 · 0 comments
Open

Passing string as error to callback #8

tacticalchihuahua opened this issue Aug 25, 2016 · 0 comments

Comments

@tacticalchihuahua
Copy link

If the dgram client errors, the callback receives an Error object, but if there is a timeout a String gets passed as the error callback which makes appropriate error handling a real pain:

https://github.com/moonpyk/node-ntp-client/blob/master/lib/ntp-client.js#L52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass error object to callback instead of string on timeout
1 participant
@tacticalchihuahua