Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework config inheritance #96

Open
wneirynck opened this issue Feb 20, 2024 · 1 comment
Open

Rework config inheritance #96

wneirynck opened this issue Feb 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@wneirynck
Copy link
Contributor

The way the processes pass on their own configuration is fundamentally flawed. It has muliple issues:

  • Serialization issues
  • Processes don't always know which settings to pass on
  • Settings can change between parent/child processes
  • Security

This should be reworked to be more robust. Configuration should be set on "driver" level, instead of inferred from the process config.

@wneirynck wneirynck added the enhancement New feature or request label Feb 20, 2024
@wneirynck
Copy link
Contributor Author

A possible alternative approach is to have processes fetch their config from the api. The drawback here is that it becomes harder to reproduce any issues, since config can change between runs. Another solution is to have processes do everything via the api, and only pass on the api url and a token. This would make it much easier to pass on configuration (since there would be almost none), at the risk of introducing a new single point of failure. This would be mitigated by having multiple replicas of the api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant