Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix EditableText and EditableHeading overflowing in the catalog #2471

Open
talkor opened this issue Oct 9, 2024 · 5 comments · May be fixed by #2555
Open

docs: fix EditableText and EditableHeading overflowing in the catalog #2471

talkor opened this issue Oct 9, 2024 · 5 comments · May be fixed by #2555
Assignees
Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest

Comments

@talkor
Copy link
Member

talkor commented Oct 9, 2024

In the Catalog there are interactive examples of components.

The EditableText and EditableHeading examples are overflowing. See screenshots:
Screenshot 2024-10-09 at 18 28 12

Screenshot 2024-10-09 at 18 28 22

Need to make them stretch, for example like the Heading:
Screenshot 2024-10-09 at 18 28 44

Related files

packages/core/src/storybook/components/related-components/descriptions/editable-text-description.tsx
packages/core/src/storybook/components/related-components/descriptions/editable-heading-description.jsx


Monday ticket [internal]

@talkor talkor added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest contribution welcome labels Oct 9, 2024
@moonlander101
Copy link

Hello, I would like to work on this

@tamirazrab
Copy link
Contributor

Hi, I tried it, removing max-width: 100%; inside editableTypography , my guess is it only allows the width of actual text there is, it got expanded but I'm not confident whether it's the right solution. Is there better approach to it?

Reference: packages/core/src/components/EditableTypography/EditableTypography.module.scss

@talkor
Copy link
Member Author

talkor commented Oct 13, 2024

Hi, I tried it, removing max-width: 100%; inside editableTypography , my guess is it only allows the width of actual text there is, it got expanded but I'm not confident whether it's the right solution. Is there better approach to it?

Reference: packages/core/src/components/EditableTypography/EditableTypography.module.scss

Hi @tamirazrab , thanks for looking into it! No need to change the component itself, but probably in the description component listed in the issue description. I believe it's due to the flex container which can be converted to a block

@mashazyu
Copy link

@talkor ,

If this issue is still available for grabs, I'd like to look into it.

@talkor
Copy link
Member Author

talkor commented Oct 20, 2024

@talkor ,

If this issue is still available for grabs, I'd like to look into it.

Sure @mashazyu, that would be great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest
Projects
None yet
4 participants