Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dialogs inside Modal are not clickable #2004

Open
ramarm opened this issue Mar 9, 2024 · 3 comments
Open

[Bug]: Dialogs inside Modal are not clickable #2004

ramarm opened this issue Mar 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ramarm
Copy link

ramarm commented Mar 9, 2024

Vibe version

2.94.0

Describe the bug

When putting a combobox inside a modal the combobox search is not click and reachable.

Expected behavior

The search should be searchable

Steps to reproduce

Example video - https://www.loom.com/share/810d255d964442a285fcb19c12068767?sid=fc38a874-7b2e-43c5-99b7-4c3d8db1c218
Example code - https://github.com/ramarm/vibe-bug

Reproduction example link

No response

System Info

No response

Additional context, Screenshots

No response

@ramarm ramarm added the bug Something isn't working label Mar 9, 2024
@ramarm
Copy link
Author

ramarm commented Mar 9, 2024

I noticed this behaviour appears also for the component

@talkor
Copy link
Member

talkor commented Mar 10, 2024

Thanks @ramarm! It appears that when the Combobox is within the Modal it's being rendered outside the modal content node, hence in the overlay area which is unclickable. As a workaround you can give the Modal an id and give it to the Dialog as containerSelector. See this example.

As the issue is not specifically about Search in Modal but wider let's keep this issue open and resolve it globally.

@talkor talkor changed the title [Bug]: Search is not clickable inside modal [Bug]: Dialogs inside Modal are not clickable Mar 10, 2024
@ramarm
Copy link
Author

ramarm commented Mar 10, 2024

@talkor Thank you, this workaround worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants