Update ODK profile.txt & fix build freezes
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: profile.txt: Removed most checks that occur during prepare_release, mainly because they are not relevant.
joeflack4
commented
Jul 3, 2024
| ERROR multiple_definitions | ||
| ERROR multiple_equivalent_classes | ||
| ERROR multiple_labels | ||
| INFO invalid_xref |
There was a problem hiding this comment.
The changes
Nico did this in this commit, as part of #600. But I felt it might help to have this show up as its own PR.
There was a problem hiding this comment.
QC build
This change was also applied to
- Exact synonym updates #600: commit
And the build was ran for it, which succeeded: - Exact synonym updates - Build 1 #601
matentzn
approved these changes
Jul 4, 2024
twhetzel
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #602
Overview
Update ODK
profile.txt to remove most checks that occur duringprepare_release`, mainly because they are not relevant.Also fixes #602, which occurs as a result of one or more of these checks taking a very long or indefinite amount of time as of #600.
Pre-merge checklist
Documentation
Was the documentation added/updated under
docs/?QC
Was the full pipeline run before submitting this PR using
sh run.sh make build-mondo-ingeston this branch (afterdocker pull obolibrary/odkfull:dev), and no errors occurred?This change was also applied to
And the build was ran for it:
New Packages
Were any new Python packages added?
Were any other non-Python packages added?
PR Review and Conversations Resolved
Has the PR been sufficiently reviewed by at least 1 team member of the Mondo Technical team and all threads resolved?