Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label and definition modifications for SEPIO:0000187 Confidence level #42

Open
pfabry opened this issue Jun 6, 2023 · 4 comments
Open

Comments

@pfabry
Copy link
Contributor

pfabry commented Jun 6, 2023

Confidence level is currently defined as: "A data item that quantifies the level of confidence an agent has that a particular piece of information is true."
A confidence level quantifying a level of confidence seems circular to us.

Moreover, since confidence level is asserted as a subclass of measurement datum, its definition should read: "A measurement datum that [...]"

Suggested label: confidence level measurement datum
This can avoid a confusion with a possible mental entity that would be the confidence level of some agent.

@matentzn
Copy link
Member

matentzn commented Jun 7, 2023

@pfabry thank you for the issue!

Would you feel confident to make a PR to that end? I will try to wave it through.

@pfabry
Copy link
Contributor Author

pfabry commented Jun 7, 2023

@matentzn Thank you for your swift answer! Will do a PR :-)

Also, a confidence level is axiomatized as being about a statement and it seems it could be used in the definition.
The proposed definition would read as follows: "A measurement datum that quantifies the level of confidence an agent has that a particular statement is true."

pfabry added a commit to pfabry/SEPIO-ontology that referenced this issue Jun 9, 2023
New definition: "A measurement datum that quantifies the level of confidence an agent has that a particular statement is true."
cf. issue monarch-initiative#42
mbrush added a commit to pfabry/SEPIO-ontology that referenced this issue Jun 12, 2023
minor edits to 'confidence level' text definition and subclass axiom based on comments in monarch-initiative#42
@mbrush
Copy link
Member

mbrush commented Jun 12, 2023

Thanks for the feedback @pfabry. I agree with your proposal but would change the axiom on this class to real 'is about some information content entity', and adjust your proposed definition accordingly. Confidence levels can be about other types of information besides statements. I amended your PR accordingly. Let me know if this sounds reasonable, and I can approve the change.

Also, please note the text I added to the SEPIO readme file, concerning the development status of the SEPIO Ontology. This includes a warning for users that this still a pre-release version that will undergo some refactoring ahead of an official first release later this year - mainly to align with work in the GA4GH Variant Annotation effort which is where the information model underlying SEPIO is currently evolving to support use cases coming from this project.

@pfabry
Copy link
Contributor Author

pfabry commented Jun 12, 2023

That sounds perfectly reasonable to us. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants