New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify handling of fixations. #97

Open

4 tasks

molpopgen opened this issue Mar 7, 2018 · 1 comment

Labels

API enhancement

Owner

molpopgen commented Mar 7, 2018 •

edited

Loading

Placeholder issue for now...

The current handling of fixations is not ideal:

it leads to modeling errors
the pruning policy stuff affects efficiency of fitness calculations.

Any fixes will break API...

To address this:

Fixations should always be removed.
Neutral/selected fixations should be separated in population objects
Genetic value functions need updating to calculate the contribution of fixations each generation and apply that to each diploid.
Meta-populations and multi-locus simulations may need special thought. For the latter, selected fixations will need sorting by position to match them up to each locus.

molpopgen changed the title ~~Unify han~~ Unify handling of fixations.

molpopgen added enhancement API labels

molpopgen added this to the 0.6.0 milestone

molpopgen modified the milestones: 0.6.0, 0.7.0

molpopgen removed this from the 0.7.0 milestone

Owner Author

molpopgen commented Nov 14, 2018

Tree sequence recording makes this a bit less pressing? See #167, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment