Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a proper tree sequence. #344

Open
molpopgen opened this issue Jun 13, 2021 · 1 comment · May be fixed by #349
Open

Need a proper tree sequence. #344

molpopgen opened this issue Jun 13, 2021 · 1 comment · May be fixed by #349
Milestone
0.10.0

Comments

@molpopgen
Copy link
Owner

The current tree visitor is hacky. We should adopt what we've done in forrustts as a model for fwdpp. Some ownership semantics may be a bit trickier, though. It seems that shared_ptr will work, but it isn't "safe" (in a rusty sense), as the consumer could delete it. Sigh.
@molpopgen molpopgen added this to the 0.10.0 milestone Jun 13, 2021
@molpopgen molpopgen mentioned this issue Jun 14, 2021
Open
@molpopgen
Copy link
Owner Author

This is the same issue as #294. Apparently I'm in issue groundhog day.

@molpopgen molpopgen linked a pull request Jul 6, 2021 that will close this issue
add tree sequence #349
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

add tree sequence molpopgen/fwdpp
1 participant
@molpopgen