Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings #244

Open
molpopgen opened this issue Feb 17, 2020 · 2 comments
Open

Compiler warnings #244

molpopgen opened this issue Feb 17, 2020 · 2 comments

Comments

@molpopgen
Copy link
Owner

There are currently lots of warnings due to implicit conversions. These need to be checked and fixed. A lot of the solution will be to use auto liberally!

These flags will be key:

./configure --enable-debug=yes CPPFLAGS='-Wall -W -Weffc++ -Wconversion'
@molpopgen molpopgen mentioned this issue Mar 11, 2021
Merged
@molpopgen
Copy link
Owner Author

On GCC, we need -Wsign-conversion, too.

@molpopgen
Copy link
Owner Author

On GCC, we need -Wsign-conversion, too.

Will punt on this, as it imposes a ridiculous constraint on array indexing.

molpopgen added a commit that referenced this issue Apr 29, 2021
@molpopgen
Silence compiler warnings. (#342)
9c92e51 
Closes #244
@molpopgen molpopgen mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen