Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to handle side effects of fixation removal #214

Open
molpopgen opened this issue Jul 12, 2019 · 2 comments
Open

Add function to handle side effects of fixation removal #214

molpopgen opened this issue Jul 12, 2019 · 2 comments

Comments

@molpopgen
Copy link
Owner

Adding site tables (#211) creates side-effects for simulations where fixations are "pruned". The required operations should be abstracted out into a function in fwdpp::ts.

@molpopgen
Copy link
Owner Author

Note for future self: we need a function to prune fixations from the tree sequences. There are two strategies one can envision:

  1. Remove mutations that lead to all alive nodes and zero preserved nodes. This method removes a subset of fixations.
  2. Remove all mutations that are on the root nodes of marginal trees with only 1 root. Without ancient samples, this accomplishes exactly what we want w/o the need for sample list updating.

@molpopgen molpopgen modified the milestones: 0.8.0, 0.9.0 Mar 12, 2020
@molpopgen
Copy link
Owner Author

I want to delay this until after #225 and #283 are dealt with. This one requires thinking.

@molpopgen molpopgen removed this from the 0.9.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant