Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP proxies #63

Closed
willemstuursma opened this issue Mar 8, 2017 · 8 comments
Closed

Add support for HTTP proxies #63

willemstuursma opened this issue Mar 8, 2017 · 8 comments

Comments

@willemstuursma
Copy link
Contributor

There is no way to set HTTP proxies now.

@ghost
Copy link

ghost commented Mar 30, 2017

Hi Willem 👋

There are some problems I'd like to resolve before I contribute (I'd like to contribute to this issue since this affects me too); Are you expecting to use the native cURL proxy method? If so, there are various options regarding authentication. See the documentation that has some (version problems) and are you trying to support all various ways of authentication?

Let me know how you'd see this solution.

Thanks,
Ricardo.

@willemstuursma
Copy link
Contributor Author

I guess we should have a connection string similar to Guzzle Options for setting the proxy. The Mollie_Api_Client will then set the right properties on the cURL resource.

/cc @mollierobbert

@ghost
Copy link

ghost commented Mar 31, 2017

Let me know what your opinion is @mollierobbert. Thanks! 👍

@willemstuursma
Copy link
Contributor Author

@mollierobbert is pretty busy today. If it works for Guzzle, it'll work for us too, so go ahead.

@willemstuursma
Copy link
Contributor Author

@Ricknox any luck with this?

@holtkamp
Copy link
Contributor

holtkamp commented Feb 3, 2018

Similar issue and PR can be found here: link0/bunq#27

@willemstuursma
Copy link
Contributor Author

@holtkamp That's a pretty unique requirement of bunq.

Regardless, I think we will release a v2 of this API client somewhere in 2018H1, which will probably use a Guzzle ClientInterface that you can optionally inject.

@willemstuursma
Copy link
Contributor Author

This will be available in 2.0, which uses Guzzle as the transport. Guzzle can be configured to use proxies and can be injected in the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants